Preserve descriptors when writing to layout #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently compute these manually, but that drops platform information and annotations. Keep these instead so it's easy to put together an index using crane pull.
Codecov Report
@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
+ Coverage 74.09% 74.15% +0.05%
==========================================
Files 113 113
Lines 8481 8453 -28
==========================================
- Hits 6284 6268 -16
+ Misses 1587 1579 -8
+ Partials 610 606 -4
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently compute these manually, but that drops platform information
and annotations. Keep these instead so it's easy to put together an
index using crane pull.