Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap progress updates in a mutex #1402

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr commented Jun 29, 2022

Atomically incrementing the number of bytes written isn't sufficient if
we're sending the updates out of order.

I ran the progress tests 50 times after this change and they passed.

@jonjohnsonjr jonjohnsonjr force-pushed the progress branch 2 times, most recently from 12e6ec3 to 9dc0cf4 Compare June 29, 2022 21:08
pkg/v1/remote/progress.go Show resolved Hide resolved
pkg/v1/remote/progress.go Show resolved Hide resolved
Atomically incrementing the number of bytes written isn't sufficient if
we're sending the updates out of order.

I ran the progress tests 50 times after this change and they passed.
@codecov-commenter
Copy link

Codecov Report

Merging #1402 (9dc0cf4) into main (59b5c06) will increase coverage by 0.01%.
The diff coverage is 96.92%.

❗ Current head 9dc0cf4 differs from pull request most recent head b3f8daf. Consider uploading reports for the commit b3f8daf to get more accurate results

@@            Coverage Diff             @@
##             main    #1402      +/-   ##
==========================================
+ Coverage   74.14%   74.15%   +0.01%     
==========================================
  Files         113      114       +1     
  Lines        8450     8455       +5     
==========================================
+ Hits         6265     6270       +5     
  Misses       1579     1579              
  Partials      606      606              
Impacted Files Coverage Δ
pkg/v1/remote/write.go 63.50% <93.54%> (-1.11%) ⬇️
pkg/v1/remote/multi_write.go 62.92% <100.00%> (ø)
pkg/v1/remote/progress.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59b5c06...b3f8daf. Read the comment docs.

@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review June 29, 2022 21:21
@jonjohnsonjr jonjohnsonjr merged commit 86f0c4a into google:main Jun 29, 2022
@jonjohnsonjr jonjohnsonjr deleted the progress branch June 29, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants