Implement crane edit #1403
Merged
Implement crane edit #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1403 +/- ##
==========================================
- Coverage 74.15% 73.40% -0.76%
==========================================
Files 114 115 +1
Lines 8455 8758 +303
==========================================
+ Hits 6270 6429 +159
- Misses 1579 1687 +108
- Partials 606 642 +36
Continue to review full report at Codecov.
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jonjohnsonjr
force-pushed
the
edit
branch
2 times, most recently
from
d7d0e94
to
9af1103
Compare
imjasonh
approved these changes
Jul 13, 2022
cmd/crane/cmd/edit.go
Outdated
| return nil, err | ||
| } | ||
| if _, ok := ref.(name.Digest); ok { | ||
| dst = fmt.Sprintf("%s@%s", ref.Context(), digest) |
There was a problem hiding this comment.
nit: ref.Context().Digest(digest) all over the place
This works at least on linux with neovim. If stdin appears to be interactive, crane edit will open an editor with the contents of the target manifest/config/file. Otherwise, crane edit will read the desired contents from stdin and just overwrite them for the target.
imjasonh
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works at least on linux with neovim. If stdin appears to be
interactive, crane edit will open an editor with the contents of the
target manifest/config/file. Otherwise, crane edit will read the desired
contents from stdin and just overwrite them for the target.