Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to no mount if registry misbehaves #1406

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

jonjohnsonjr
Copy link
Collaborator

Sometimes we see authentication errors if the from repo doesn't exist,
so fall back to just initiating an upload without a mount attempt.

Fixes #1404

Sometimes we see authentication errors if the from repo doesn't exist,
so fall back to just initiating an upload without a mount attempt.
@imjasonh
Copy link
Collaborator

Should we cut a v0.10.1 for this?

@codecov-commenter
Copy link

Codecov Report

Merging #1406 (bda690f) into main (4d7b65b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1406      +/-   ##
==========================================
+ Coverage   74.15%   74.16%   +0.01%     
==========================================
  Files         114      114              
  Lines        8455     8459       +4     
==========================================
+ Hits         6270     6274       +4     
  Misses       1579     1579              
  Partials      606      606              
Impacted Files Coverage Δ
pkg/v1/remote/write.go 63.73% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d7b65b...bda690f. Read the comment docs.

@jonjohnsonjr jonjohnsonjr merged commit ddd39fb into google:main Jul 12, 2022
@jonjohnsonjr jonjohnsonjr deleted the mount-fallback branch July 12, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crane: unable to copy between to registries (registry.gitlab.com and docker.io)
3 participants