Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop localhost to support crane registry serve in a container #1746

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

mattmoor
Copy link
Collaborator

This allows you to run docker run -e PORT=1234 --name foo.local cgr.dev/chainguard/crane registry serve and then --link foo.local to push to foo.local:1234.

Right now it only listens on the loopback interface, so unless it's run in a K8s-style pod with something that exposes and proxies things (e.g. like Knative / Cloud Run), it is inaccessible.

Signed-off-by: Matt Moore <mattmoor@chainguard.dev>
@codecov-commenter
Copy link

Codecov Report

Merging #1746 (8f30f61) into main (fe268b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1746   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files         122      122           
  Lines        9827     9827           
=======================================
  Hits         7069     7069           
  Misses       2077     2077           
  Partials      681      681           

@mattmoor mattmoor merged commit b850480 into google:main Jun 25, 2023
18 checks passed
@mattmoor mattmoor deleted the support-non-localhost branch June 25, 2023 23:33
@ewhauser
Copy link

@mattmoor - this causes network error warnings on MacOS:

Screenshot 2023-11-19 at 1 52 47 PM

Bazel's rules_oci makes use of crane so you end up with a warning for every image you are building which is untenable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants