Don't wrap DefaultKeychain with refreshes #1791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heuristic only works well if the upstream keychain doesn't do any caching. This is usually the case, but I've run into a couple situations where the hardcoded 5 minutes does not overlap well with certain cred helper implementations. Undoing that wrap allows callers to set a time that makes sense for them. With the wrap, there's not any direct reference to DefaultKeychain, which feels... bad.
imjasonh
approved these changes
Sep 19, 2023
maximilianbraun
added a commit
to crossplane-contrib/xp-testing
that referenced
this pull request
Dec 11, 2023
….17.0 (#35) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/google/go-containerregistry](https://togithub.com/google/go-containerregistry) | require | minor | `v0.16.1` -> `v0.17.0` | --- ### Release Notes <details> <summary>google/go-containerregistry (github.com/google/go-containerregistry)</summary> ### [`v0.17.0`](https://togithub.com/google/go-containerregistry/releases/tag/v0.17.0) [Compare Source](https://togithub.com/google/go-containerregistry/compare/v0.16.1...v0.17.0) #### What's Changed - 🦅 Validate index architectures match children 🦅 by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [google/go-containerregistry#1776 - Set Content-Length for blob uploads by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [google/go-containerregistry#1781 - Don't wrap DefaultKeychain with refreshes by [@​jonjohnsonjr](https://togithub.com/jonjohnsonjr) in [google/go-containerregistry#1791 - Build releases with Go 1.21 by [@​imjasonh](https://togithub.com/imjasonh) in [google/go-containerregistry#1840 - fix: mimic oci-layout in diskblobhandler by [@​thesayyn](https://togithub.com/thesayyn) in [google/go-containerregistry#1810 - tag: add command explanation to the long help by [@​abitrolly](https://togithub.com/abitrolly) in [google/go-containerregistry#1843 - feat: implement gc command by [@​thesayyn](https://togithub.com/thesayyn) in [google/go-containerregistry#1811 - feat: allow port and disk path to be overriden by [@​thesayyn](https://togithub.com/thesayyn) in [google/go-containerregistry#1848 **Full Changelog**: google/go-containerregistry@v0.16.1...v0.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/crossplane-contrib/xp-testing). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuODcuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The heuristic only works well if the upstream keychain doesn't do any caching. This is usually the case, but I've run into a couple situations where the hardcoded 5 minutes does not overlap well with certain cred helper implementations.
Undoing that wrap allows callers to set a time that makes sense for them. With the wrap, there's not any direct reference to DefaultKeychain, which feels... bad.