Add remote.WithJobs and use it in remote.MultiWrite #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #803 +/- ##
==========================================
- Coverage 75.60% 74.88% -0.72%
==========================================
Files 102 103 +1
Lines 4185 4312 +127
==========================================
+ Hits 3164 3229 +65
- Misses 566 606 +40
- Partials 455 477 +22
Continue to review full report at Codecov.
|
jonjohnsonjr
reviewed
Nov 2, 2020
jonjohnsonjr
reviewed
Nov 2, 2020
imjasonh
force-pushed
the
with-parallel
branch
from
d085892
to
2265d79
Compare
imjasonh
changed the title
jonjohnsonjr
reviewed
Nov 2, 2020
imjasonh
force-pushed
the
with-parallel
branch
from
2265d79
to
a4fb466
Compare
- default parallel is 4 - an error is returned if WithParallel is called with a value <= 0 We can probably reuse this to fetch and push blobs elsewhere in remote. MultiWrite'ing 123 distroless images with WithJobs(100) took 4s compared to 11s for the default.
imjasonh
force-pushed
the
with-parallel
branch
from
a4fb466
to
7e43cbb
Compare
jonjohnsonjr
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can probably reuse this to fetch and push blobs elsewhere in remote.
MultiWrite'ing 123 distroless images with
WithParallel(100)took 4s compared to 11s for the default.