Return both https and http errors on ping fallback #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we just return the last one, which is very misleading if you're using self-signed certs for a domain that allows http fallback (e.g. localhost).
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
==========================================
+ Coverage 74.32% 74.35% +0.02%
==========================================
Files 106 106
Lines 4452 4464 +12
==========================================
+ Hits 3309 3319 +10
- Misses 650 651 +1
- Partials 493 494 +1
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we just return the last one, which is very misleading if
you're using self-signed certs for a domain that allows http fallback
(e.g. localhost).
Fixes #738