Fix crane append for named pipes
#868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's annoying that `crane append` is hard to use with one-liners, which is the secret goal of most crane commands. We now stat the layer files and use a streaming layer for anything that's not a regular file, which includes named pipes, which fail if we try to open them multiple times. Now you can do this: $ crane append -f <(tar -c some-dir/ -f -) -t $IMAGE
jonjohnsonjr
force-pushed
the
crane-append-stream
branch
from
b872f8b
to
957dda9
Compare
Codecov Report
@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 74.33% 74.26% -0.08%
==========================================
Files 106 106
Lines 4458 4465 +7
==========================================
+ Hits 3314 3316 +2
- Misses 651 655 +4
- Partials 493 494 +1
Continue to review full report at Codecov.
|
imjasonh
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #707 as well
It's annoying that
crane appendis hard to use with one-liners, whichis the secret goal of most crane commands. We now stat the layer files
and use a streaming layer for anything that's not a regular file, which
includes named pipes, which fail if we try to open them multiple times.
Now you can do this: