Include target resource in credential warning #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
reviewed
Dec 21, 2020
| @@ -49,7 +49,7 @@ func WithAuthFromKeychain(keys authn.Keychain) ListerOption { | |||
| return err | |||
| } | |||
| if auth == authn.Anonymous { | |||
| logs.Warn.Println("No matching credentials were found, falling back on anonymous") | |||
| logs.Warn.Printf("No matching credentials were found for %q, falling back on anonymous", l.repo.Registry) | |||
There was a problem hiding this comment.
Does this need a newline?
There was a problem hiding this comment.
Nope, from https://golang.org/pkg/log/:
Every log message is output on a separate line: if the message being printed does not end in a newline, the logger will add one.
mattmoor
approved these changes
Dec 21, 2020
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
=======================================
Coverage 74.14% 74.14%
=======================================
Files 107 107
Lines 4567 4567
=======================================
Hits 3386 3386
Misses 672 672
Partials 509 509
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be slightly less confusing the first time you see it, we can look at removing this entirely by skipping ping and only falling back on 401, but that might take a while to implement.