Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push event's Pusher is not the correct type #2998

Closed
caseyduquettesc opened this issue Nov 23, 2023 · 0 comments · Fixed by #2999
Closed

Push event's Pusher is not the correct type #2998

caseyduquettesc opened this issue Nov 23, 2023 · 0 comments · Fixed by #2999

Comments

@caseyduquettesc
Copy link
Contributor

The Push event includes a Pusher, which only has four fields:

  • date
  • email
  • name
  • username

The PushEvent type includes a Pusher, but the type is a full User object, which not only will have most fields unfilled, but more importantly, the username from the webhook is lost because a typical User includes a login, not username.

https://docs.github.com/en/webhooks/webhook-events-and-payloads#push

These should probably be distinct objects, much like Repository and PushEventRepository are distinct.

I'll send a PR for this in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant