Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Queues break repository ruleset unmarshaling #3098

Closed
siddharthab opened this issue Mar 11, 2024 · 8 comments · Fixed by #3131
Closed

Merge Queues break repository ruleset unmarshaling #3098

siddharthab opened this issue Mar 11, 2024 · 8 comments · Fixed by #3131

Comments

@siddharthab
Copy link

In the unmarshaling code, there is no case for merge_queue, and so the unmarshaling says that the rule type is not supported and errors out (full list of possible types from GitHub).

Also, the error message has the wrong format verb, it should be %q or %s instead of %T.

To reproduce, create a ruleset with merge queues set, and try to get it using go-github.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 12, 2024

Do you want to write a PR for this, @siddharthab , or should I open this up to other contributors to this repo?

@siddharthab
Copy link
Author

Because I am new to the repo, it may take me longer to make a proper well tested change. Best to have more familiar people do it. Thanks for the quick reply!

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 12, 2024

This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!

Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.

Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to go generate ./... and don't use force-push to your PRs.)

Thank you!

@Matthew-Reidy
Copy link
Contributor

Hello, I am new to open source and would like to have a crack at this though I wont be able to work on it until the weekend.

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 1, 2024

Hello, I am new to open source and would like to have a crack at this though I wont be able to work on it until the weekend.

Awesome! Thank you, @Matthew-Reidy ! We appreciate your contributions in advance!
It's yours.

@Matthew-Reidy
Copy link
Contributor

Hello, I began working on this yesterday but cant seem to find what parameters are required for merge_queue. Does anyone know this info? Im finding conflicting documentation. Thanks

@Matthew-Reidy
Copy link
Contributor

Matthew-Reidy commented Apr 18, 2024

Ah never-mind. I found the documentation. Looks like Merge_Queue rule does not require parameters.

https://docs.github.com/en/graphql/reference/unions#ruleparameters

@Matthew-Reidy
Copy link
Contributor

Submitted my PR for the changes requested here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants