New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for new Pull Request Reviews preview API. #495
Comments
I'd like to work on this @shurcooL. Can you please help me in getting started? |
Hi! @sahildua2305 I started to work on this now to use this API for my personal project, and it's in progress. As for the progress, I just only implemented |
@haya14busa thanks for offering. I'd really like to work on this. However, I'll need help in getting started. I'm new to Go. |
I think you can add rest of methods like this master...haya14busa:pull-reviews I guess we can also use |
Thanks for offering to work on this, @sahildua2305 and @haya14busa. How about @sahildua2305 takes this and @haya14busa, you can help out with reviewing the PR and iterating on it as needed?
I've looked at the new API. It's 6 new endpoints, and they're quite similar/related to pull requests. I agree with @haya14busa, it looks like simply adding them to the existing So, let's go with adding 6 methods to For example, Get a single review endpoint can look like this (rough draft to give you a starting point): // GetReview gets a single review for the specified pull request.
//
// GitHub API docs: https://developer.github.com/v3/pulls/reviews/#get-a-single-review
func (s *PullRequestsService) GetReview(owner string, repo string, number int, reviewID int) (*PullRequestReview, *Response, error) {
...
} @sahildua2305, you can look at @haya14busa's current implementation, it's quite good so far, with the exception that you want to go with the existing Feel free to make a PR as soon as you have something started, if you'd like early feedback or to make sure you're on the right path. Thanks again! |
Thank you for the response, @shurcooL! Ok, I'm happy to help @sahildua2305! Please notify me when you open a pull request or want some helps. |
Thanks for your response, @shurcooL! Also thank you for offering help, @haya14busa. I'll inform you as I open the PR soon. |
@shurcooL @haya14busa I am just getting started with my work on this. How do I test my changes? |
First, make sure all existing tests pass by running You can write a simple program that exercises your new code and hits the real GitHub API, and see if it works as expected. Then write unit tests that are similar to the ones that exist. It helps to get a real GitHub API response and make your mock handler return something equivalent. Also see the unit test that @haya14busa wrote in ebd6006. |
Thanks @shurcooL! I got everything (related to environment and existing tests) working. I will test my changes, write tests and create a PR once at least one endpoint is covered. |
This commit adds only one of the total 6 endpoints made available for developers preview. This is for initial review by other contributors. Once reviewed, other endpoints will be added as well. Partly fixes google#495
This commit adds only one of the total 6 endpoints made available for developers preview. Partly fixes google#495 EDIT: Fix minor things based on initial review.
FYI: Preview Review Requests API is also released Announcement: https://developer.github.com/changes/2016-12-16-review-requests-api/ |
This commit adds only one of the total 6 endpoints made available for developers preview. Partly fixes google#495 EDIT: Fix minor things based on initial review.
This commit adds only one of the total 6 endpoints made available for developers preview. Partly fixes google#495 EDIT: Fix minor things based on initial review.
This commit adds only one of the total 6 endpoints made available for developers preview. Partly fixes google#495 EDIT: Fix minor things based on initial review.
Fixes google#495. Closes google#497. Change-Id: If266972e7a20f83afaa842d54c22846bbb435328
Announcement: https://developer.github.com/changes/2016-12-14-reviews-api/.
Docs: https://developer.github.com/v3/pulls/reviews/.
This was announced today.
The text was updated successfully, but these errors were encountered: