Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'review_requested' and 'review_request_removed' to PullRequestEvent action #790

Closed
sungwoncho opened this issue Nov 22, 2017 · 5 comments
Closed

Add 'review_requested' and 'review_request_removed' to PullRequestEvent action #790

sungwoncho opened this issue Nov 22, 2017 · 5 comments
Assignees
@scriptonist
Labels
enhancement good first issue

Comments

@sungwoncho
Copy link

PullRequestEvent action is missing 'review_requested' and 'review_request_removed'.

It would be an enhancement to add them.

https://developer.github.com/v3/activity/events/types/#pullrequestevent
@scriptonist
Copy link
Contributor

@shurcooL Let me take this Issue

@dmitshur
Copy link
Member

It's all yours. Thank you.

@scriptonist
Copy link
Contributor

According to the API Docs

Deliveries for review_requested and review_request_removed events will have an additional field called requested_reviewers.

Should I add this field to PullRequestEvent? If so what will it's type be ?, an [] *User ?

@dmitshur
Copy link
Member

dmitshur commented Nov 23, 2017 •
edited
Loading

That sounds right to me. It should go in the Webbook section of fields.

@scriptonist
Copy link
Contributor

scriptonist commented Nov 23, 2017 •
edited
Loading

@shurcooL I believe It's a [] *User.On testing I got a response like this
"requested_reviewers":[ { <user> } ],

@scriptonist scriptonist mentioned this issue Nov 23, 2017
Merged
dmitshur pushed a commit that referenced this issue Nov 24, 2017
@scriptonist @dmitshur
Add PullRequestEvent.RequestedReviewers field. (#792)
872b370 
Document "review_requested" and "review_request_removed" actions in PullRequestEvent.

GitHub API docs: https://developer.github.com/v3/activity/events/types/#pullrequestevent.

Fixes #790.
@rallytime rallytime mentioned this issue Feb 7, 2018
Open
nbareil pushed a commit to nbareil/go-github that referenced this issue May 1, 2018
@scriptonist @dmitshur
Add PullRequestEvent.RequestedReviewers field. (google#792)
cb8c0a6 
Document "review_requested" and "review_request_removed" actions in PullRequestEvent.

GitHub API docs: https://developer.github.com/v3/activity/events/types/#pullrequestevent.

Fixes google#790.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scriptonist scriptonist

Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dmitshur @sungwoncho @scriptonist