Make use of testHeader and testMethod consistent #829
Assignees
Comments
|
sounds good to me. assigned to you. |
sahildua2305
added a commit
to sahildua2305/go-github
that referenced
this issue
Jan 14, 2018
Use testMethod to test the request method instead of manually comparing it and testing. This change is to make things consistent through out the code base. Fixes google#829
gmlewis
pushed a commit
that referenced
this issue
Jan 16, 2018
Use testMethod to test the request method instead of manually comparing it and testing. This change is to make things consistent through out the code base. Fixes #829.
nbareil
pushed a commit
to nbareil/go-github
that referenced
this issue
May 1, 2018
Use testMethod to test the request method instead of manually comparing it and testing. This change is to make things consistent through out the code base. Fixes google#829.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As found out while reviewing #817, we have some inconsistencies in our tests where some of the tests don't use the
testHeaderandtestMethodfunctions to test request header and method.One of the defaulter is https://github.com/google/go-github/blob/master/github/git_trees_test.go#L22.
This is completely harmless. Though it's important to make sure it doesn't cause further confusion for the new contributors as it did in that PR initially.
Via this issue, I'd like to point it out and mention that I'd like to fix this inconsistency.
The text was updated successfully, but these errors were encountered: