Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support preview GraphQL API v4 Node IDs #817
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
Once you've signed, please reply here (e.g.
This is a large change, thank you for taking it on @anubhakushwaha!
It's looking great at a high level so far. I've spotted a few minor issues and change suggestions for you to consider, see inline comments.
A few minor comments. Otherwise this is looking good, not seeing other issues or opportunities for improvement.
It's hard to verify definitively which exact objects get the new
NodeID field. I tried to confirm, and it looks good, but I can't give definitive guarantees. For example, I'm not quite sure if
DeploymentStatus should get
NodeID (it probably should, but I'm not 100% confident). GitHub documentation doesn't make it very easy to know for sure, so I think this is as good as it can be for the first version.
So there's good news and bad news.
Note to project maintainer: This is a terminal state, meaning the