Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support go1.13 #1279

Merged
merged 1 commit into from
Sep 7, 2019
Merged

Support go1.13 #1279

merged 1 commit into from
Sep 7, 2019

Conversation

gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Sep 7, 2019

Add support for go1.13 and bump Travis CI tests from 1.11 to 1.12 and 1.13.

@googlebot googlebot added the cla: yes Indication that the PR author has signed a Google Contributor License Agreement. label Sep 7, 2019
@codecov
Copy link

codecov bot commented Sep 7, 2019

Codecov Report

Merging #1279 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1279   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files          86       86           
  Lines        6040     6040           
=======================================
  Hits         4435     4435           
  Misses        836      836           
  Partials      769      769

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e90302...f7d5d24. Read the comment docs.

@gmlewis gmlewis merged commit 8bb91d6 into master Sep 7, 2019
@gmlewis gmlewis deleted the go12-13 branch September 7, 2019 20:14
@willnorris
Copy link
Collaborator

You actually don't need to add 1.13 explicitly... the "1.x" version will always test the latest. So what I've been doing is test master plus the latest two version, with "1.x" always capturing the most recent version. So this should really now just be:

go:
 - "1.x"
 - "1.12.x"
 - "master"

I'd rather not go beyond these three, primarily to keep our build times down.

@gmlewis
Copy link
Collaborator Author

gmlewis commented Sep 7, 2019

Thank you, @willnorris!
I'll delete that line.

theothertomelliott added a commit to yext/edward that referenced this pull request Mar 28, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants