Use new endpoints to get and list references #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the GetRefs and ListRefs methods in favor of ListMatchingRefs, which performs both functions. The GetRef method remains the same, but now returns a standard 404 error if the reference does not exist.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #1513 +/- ##
==========================================
- Coverage 68.04% 68.04% -0.01%
==========================================
Files 94 94
Lines 8534 8502 -32
==========================================
- Hits 5807 5785 -22
+ Misses 1845 1838 -7
+ Partials 882 879 -3
Continue to review full report at Codecov.
|
gmlewis
approved these changes
Apr 30, 2020
There was a problem hiding this comment.
Thank you, @bluekeyes!
LGTM.
Awaiting second LGTM before merging.
| @@ -61,9 +61,6 @@ var ( | |||
| "AppsService.FindRepositoryInstallationByID": true, | |||
| "AuthorizationsService.CreateImpersonation": true, | |||
| "AuthorizationsService.DeleteImpersonation": true, | |||
| "GitService.GetRef": true, | |||
There was a problem hiding this comment.
Uh, wow... thank you for updating my maintenance tool for me as well!
I really appreciate that! ❤️
gmlewis
added
the
Breaking API Change
|
Thank you, @wesleimp! |
n1lesh
pushed a commit
to n1lesh/go-github
that referenced
this pull request
Oct 2, 2020
This was referenced May 28, 2021
Closed
This was referenced Jun 6, 2021
This was referenced Jun 21, 2021
Closed
1 task
This was referenced Jul 2, 2021
fix(deps): update module github.com/google/go-github/v31 to v36 - autoclosed
motemen/prchecklist#208
Closed
Closed
This was referenced Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
GetRefsandListRefsmethods in favor ofListMatchingRefs, which performs both functions. TheGetRefmethod remains the same, but now returns a standard 404 error if the reference does not exist.Closes #1512.