Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support numeric public key ids for actions #1836

Merged
merged 1 commit into from
Apr 1, 2021
Merged

Support numeric public key ids for actions #1836

merged 1 commit into from
Apr 1, 2021

Conversation

Azuka
Copy link
Contributor

@Azuka Azuka commented Mar 30, 2021

closes #1835

@google-cla
Copy link

google-cla bot commented Mar 30, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no cla: yes Indication that the PR author has signed a Google Contributor License Agreement. and removed cla: no labels Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #1836 (8d9280e) into master (3130b78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1836   +/-   ##
=======================================
  Coverage   97.56%   97.56%           
=======================================
  Files         104      104           
  Lines        6602     6618   +16     
=======================================
+ Hits         6441     6457   +16     
  Misses         87       87           
  Partials       74       74           
Impacted Files Coverage Δ
github/actions_secrets.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3130b78...8d9280e. Read the comment docs.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Azuka .
Please address the comments below.

github/actions_secrets.go Outdated Show resolved Hide resolved
github/actions_secrets.go Show resolved Hide resolved
github/actions_secrets.go Show resolved Hide resolved
@Azuka
Copy link
Contributor Author

Azuka commented Mar 31, 2021

@gmlewis thanks for reviewing. I've made the suggested changes

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 31, 2021

@gmlewis thanks for reviewing. I've made the suggested changes

Thank you, @Azuka. In the future, please don't force-push to PRs in this repo, as it makes it really difficult for the reviewers to see what changed since the last review.

github/actions_secrets.go Outdated Show resolved Hide resolved
github/actions_secrets_test.go Show resolved Hide resolved
github/actions_secrets_test.go Show resolved Hide resolved
github/actions_secrets_test.go Show resolved Hide resolved
@Azuka Azuka requested a review from gmlewis March 31, 2021 14:25
@Azuka
Copy link
Contributor Author

Azuka commented Mar 31, 2021

@gmlewis thanks for reviewing. I've made the suggested changes

Thank you, @Azuka. In the future, please don't force-push to PRs in this repo, as it makes it really difficult for the reviewers to see what changed since the last review.

I'm really sorry, I missed that.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 31, 2021

I'm really sorry, I missed that.

No problem. Next time. 😂

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Azuka !
LGTM.

Awaiting second LGTM before merging.

@gmlewis gmlewis requested a review from wesleimp March 31, 2021 21:25
Copy link
Collaborator

@wesleimp wesleimp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@gmlewis
Copy link
Collaborator

gmlewis commented Apr 1, 2021

Thank you, @wesleimp .
Merging.

@gmlewis gmlewis merged commit bf34728 into google:master Apr 1, 2021
@Azuka Azuka deleted the fix/numeric-public-key branch April 6, 2021 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indication that the PR author has signed a Google Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Action public key key ids are returned as numeric in some versions of GitHub Enterprise
3 participants