Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for User SSH signing keys #2482

merged 1 commit into from Oct 12, 2022


Copy link

Introduce support for the new SSH signing key endpoints introduced into the REST API with the introduction of SSH commit verification.

Copy link

google-cla bot commented Sep 28, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @neersighted !

Awaiting second LGTM from any other contributor to this repo before merging.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Sep 28, 2022
Copy link

gmlewis commented Sep 29, 2022

@neersighted - please use regular push of commits to this PR and not force push, as it makes it really challenging for the reviewer to see what changes each time.

We always use squash and merge in this repo anyway so it doesn't matter how many commits it takes. Thank you.

Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #2482 (c3c2c61) into master (0c3cd12) will decrease coverage by 0.04%.
The diff coverage is 89.47%.

@@            Coverage Diff             @@
##           master    #2482      +/-   ##
- Coverage   98.03%   97.99%   -0.05%     
  Files         122      123       +1     
  Lines       10705    10762      +57     
+ Hits        10495    10546      +51     
- Misses        144      148       +4     
- Partials       66       68       +2     
Impacted Files Coverage Δ
github/users_ssh_signing_keys.go 89.47% <89.47%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor Author

Fair -- I'm usually used to a "clean history" workflow -- in this case go generate was missed.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 12, 2022
Copy link

gmlewis commented Oct 12, 2022

Thank you, @valbeat !

@gmlewis gmlewis merged commit 10f65ab into google:master Oct 12, 2022
8 of 10 checks passed
@neersighted neersighted deleted the ssh_signing_keys branch October 12, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants