examples/basicauth: Simplify comma-ok type assertion in if statement. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://golang.org/ref/spec#Type_assertions: > For an expression x of interface type and a type T, the primary expression > > x.(T) > > asserts that x is not nil and that the value stored in x is of type T. > [...] > The value of ok is true if the assertion holds. Therefore, this if statement can be simplified without changing behavior.
dmitshur
force-pushed
the
basicauth-simplify-type-assertion
branch
from
c232097
to
a370a26
Compare
dmitshur
referenced
this pull request
Feb 18, 2017
Add a new error type, TwoFactorAuthError, which identifies the need to include a one-time password when using Basic Auth for a user with two-factor auth enabled. An example of using both the new transport and error type can be seen in examples/basicauth/main.go. fixes #258
bubg-dev
pushed a commit
to bubg-dev/go-github
that referenced
this pull request
Jun 16, 2017
…google#558) According to https://golang.org/ref/spec#Type_assertions: > For an expression x of interface type and a type T, the primary expression > > x.(T) > > asserts that x is not nil and that the value stored in x is of type T. [...] The > value of ok is true if the assertion holds. Therefore, this if statement can be simplified without changing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://golang.org/ref/spec#Type_assertions:
Therefore, this if statement can be simplified without changing behavior.
I also made a proposal for this check in dominikh/go-tools#34.