Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs around creating ECDAA key #285

Closed
wants to merge 4 commits into from
Closed

Fix bugs around creating ECDAA key #285

wants to merge 4 commits into from

Commits on Jun 14, 2022

  1. Fix CurveBNP256 number 

    TPM2_ECC_BN_P256 is 0x0010, not decimal number 10.
https://trustedcomputinggroup.org/wp-content/uploads/TSS_Overview_Common_Structures_Version-0.9_Revision-03_Review_030918.pdf
    @akakou
    akakou committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    f5d3a74 View commit details
    Browse the repository at this point in the history

  2. Fix ecdaa count size from 32 bit to 16 bit 

    The size of TPMS_SCHEME_ECDAA.count is 16 bit, not 32 bit.
https://trustedcomputinggroup.org/wp-content/uploads/TSS_Overview_Common_Structures_Version-0.9_Revision-03_Review_030918.pdf
    @akakou
    akakou committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    4d0c7e9 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Replace the constants for ECCurve with explicit 

    Replace all the constants in the const block for EllipticCurve with explicit values.
https://github.com/google/go-tpm/pull/285/files/4d0c7e99a29dd204448d9071b53a503cda12b2f4#r907815166
    @akakou
    akakou committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    4d0d236 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2022

  1. Merge branch 'tpmdirect' into fix-create-ecdaa-key

    @akakou
    akakou committed Jun 29, 2022
    Configuration menu
    Copy the full SHA
    4b3b117 View commit details
    Browse the repository at this point in the history