Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tpm2: Add RSADecryptWithSession #314

Merged
merged 1 commit into from May 10, 2024
Merged

tpm2: Add RSADecryptWithSession #314

merged 1 commit into from May 10, 2024

Conversation

thomasten
Copy link
Contributor

I need to use RSADecrypt with a PCR policy. I added RSADecryptWithSession similar to the already existing ...WithSession funcs.

@thomasten thomasten requested review from alexmwu, jkl73 and a team as code owners February 22, 2023 17:54
@google-cla
Copy link

google-cla bot commented Feb 22, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@3u13r
Copy link

3u13r commented May 25, 2023

We'd like to move away from our fork and back to mainline. Could someone take a look in the near future @jkl73 @alexmwu ?

@alexmwu
Copy link
Contributor

alexmwu commented May 30, 2023

This LGTM.

FYI @chrisfenner is working on a refactor of the API, which you may be interested in. https://github.com/google/go-tpm/tree/tpmdirect. We have 1:1 parameter mapping and support for most commands (with an easy route to adding new commands). We are planning a stable release at that point. As part of the tpmdirect work, we plan on deprecating the current tpm2 package.

@chrisfenner are we planning on accepting new contributions to the legacy package?

@daniel-weisse
Copy link

Can this be rebased to main and merged?

@thomasten thomasten changed the base branch from master to main June 29, 2023 07:56
@jkl73 jkl73 merged commit 5c2f088 into google:main May 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants