Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include path to gtest.h in GTMGoogleTestRunner.mm #407

Open
hiroyuki-komatsu opened this issue May 12, 2023 · 1 comment
Open

Include path to gtest.h in GTMGoogleTestRunner.mm #407

hiroyuki-komatsu opened this issue May 12, 2023 · 1 comment

Comments

@hiroyuki-komatsu
Copy link

UnitTesting/GTMGoogleTestRunner.mm has the following code to include gtest.h.

#include "third_party/gtest/include/gtest/gtest.h"

However, the actual path is (third_party/googletest/)googletest/include/gtest/gtest.h.

Would you change the include path to either of the following paths?

#include "third_party/gtest/googletest/include/gtest/gtest.h"

or

#include "third_party/googletest/googletest/include/gtest/gtest.h"

FYI. google/mozc is the project that needs this change.
https://github.com/google/mozc/blob/master/src/WORKSPACE.bazel#L142

Thank you!

hiroyuki-komatsu added a commit to google/mozc that referenced this issue May 12, 2023
* Suppress the CI error on GitHub Actions.
* To address the root cause we probably need to update the upstream of google-toolbox-for-mac.
  + google/google-toolbox-for-mac#407

#codehealth

PiperOrigin-RevId: 531506258
hiroyuki-komatsu added a commit to google/mozc that referenced this issue May 12, 2023
*** Reason for rollback ***

cl/531511096 addresses the issue in a proper way.

*** Original change description ***

Add "manual" to mozc_objc_test.macos_unit_test.

* Suppress the CI error on GitHub Actions.
* To address the root cause we probably need to update the upstream of google-toolbox-for-mac.
  + google/google-toolbox-for-mac#407

#codehealth

***

PiperOrigin-RevId: 531512979
@thomasvl
Copy link
Member

Go ahead with a patch for the second one, since I believe that's what the repo is called these days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@thomasvl @hiroyuki-komatsu and others