Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PodSpec for tvOS #140

Merged
merged 4 commits into from May 19, 2017
Merged

Fixed PodSpec for tvOS #140

merged 4 commits into from May 19, 2017

Conversation

mariohahn
Copy link
Contributor

No description provided.

@mariohahn
Copy link
Contributor Author

I rechecked it now:

{
      "name": "AddressBook",
      "source_files": "AddressBook/GTMABAddressBook.{h,m}",
      "frameworks": "AddressBook",
      "dependencies": {
        "GoogleToolboxForMac/Core": [
          "2.1.1"
        ],
        "GoogleToolboxForMac/Defines": [
          "2.1.1"
        ]
      },
      "platforms": {
        "ios": "5.0",
        "osx": "10.6"
      }
    }

Now iOS and OS X is included

@thomasvl
Copy link
Member

Interesting, the docs don't give any hit this would work, and even document it only takes one value. Is there something we can throw in a comment as to where this came from incase it has to get revisited in the future?

@mariohahn
Copy link
Contributor Author

Pod spec lint was successfully and pod ipc spec returned to correct json.

I just thought it should work because they have the options as array for all plurals like platform"s".

But I haven't found it in the documentation too.

@thomasvl thomasvl merged commit 4ae69e6 into google:master May 19, 2017
@dengm129
Copy link

#140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants