Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bzlmod internally #412

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Use bzlmod internally #412

merged 1 commit into from
Nov 15, 2023

Conversation

cpsauer
Copy link
Contributor

@cpsauer cpsauer commented Nov 14, 2023

Forms the basis for releasing with bzlmod in the future

Forms the basis for releasing with bzlmod in the future
@@ -0,0 +1,7 @@
module(
name = "google_toolbox_for_mac",
version = "3.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume we'll need to update this when we do releases and bump the version info in cocoapods?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed; that's my understanding.

Copy link
Member

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasvl thomasvl merged commit 62aff9a into google:main Nov 15, 2023
9 checks passed
@cpsauer
Copy link
Contributor Author

cpsauer commented Nov 15, 2023

Thanks for being so great to work with, Thomas :)

cpsauer added a commit to cpsauer/google-toolbox-for-mac that referenced this pull request Dec 13, 2023
bzlmod is now enabled by default. Follows up on google#412 :)
thomasvl pushed a commit that referenced this pull request Dec 14, 2023
bzlmod is now enabled by default. Follows up on #412 :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants