Skip to content

Commit

Permalink
Rollback 4fa8cfe
Browse files Browse the repository at this point in the history
Breaks the intended C++ version on some CI builds

PiperOrigin-RevId: 474022587
Change-Id: I41a58893802c90864e0f2cc3d15e6c169c59146d
  • Loading branch information
derekmauro authored and copybara-github committed Sep 13, 2022
1 parent 4fa8cfe commit 7cafeff
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
1 change: 0 additions & 1 deletion .bazelrc

This file was deleted.

9 changes: 6 additions & 3 deletions .github/workflows/gtest-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ on:
push:
pull_request:

env:
BAZEL_CXXOPTS: -std=c++14

jobs:
Linux:
runs-on: ubuntu-latest
Expand All @@ -14,7 +17,7 @@ jobs:
fetch-depth: 0

- name: Tests
run: bazel test --features=external_include_paths --test_output=errors ...
run: bazel test --cxxopt=-std=c++14 --features=external_include_paths --test_output=errors ...

MacOs:
runs-on: macos-latest
Expand All @@ -25,7 +28,7 @@ jobs:
fetch-depth: 0

- name: Tests
run: bazel test --features=external_include_paths --test_output=errors ...
run: bazel test --cxxopt=-std=c++14 --features=external_include_paths --test_output=errors ...


Windows:
Expand All @@ -37,4 +40,4 @@ jobs:
fetch-depth: 0

- name: Tests
run: bazel test --features=external_include_paths --test_output=errors ...
run: bazel test --cxxopt=-std=c++14 --features=external_include_paths --test_output=errors ...
1 change: 1 addition & 0 deletions ci/linux-presubmit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ time docker run \
--workdir="/src" \
--rm \
--env="CC=/usr/local/bin/gcc" \
--env="BAZEL_CXXOPTS=-std=c++14" \
${LINUX_GCC_FLOOR_CONTAINER} \
/usr/local/bin/bazel test ... \
--copt="-Wall" \
Expand Down
1 change: 1 addition & 0 deletions ci/macos-presubmit.sh
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ for absl in 0 1; do
${BAZEL_BIN} test ... \
--copt="-Wall" \
--copt="-Werror" \
--cxxopt="-std=c++14" \
--define="absl=${absl}" \
--features=external_include_paths \
--keep_going \
Expand Down

0 comments on commit 7cafeff

Please sign in to comment.