gops does not validate time duration parameter

[el10savio]

It looks like gops does not validate the input time duration parameter & defaults to 0 for invalid inputs. When testing out the hello world example adding values such as 0,-1,1.2,.. defaults to 0 and does not return an error as shown below.

$ gops 24966 3
parent PID:     24876                                        
threads:        6                                     
memory usage:   0.039%
cpu usage:      0.000%
cpu usage (3s): 0.000%
username:       admin
cmd+args:       /tmp/go-build400100092/b001/exe/main
elapsed time:   08:04
local/remote:   127.0.0.1:34409 <-> 0.0.0.0:0 (LISTEN)

$ gops 24966 0
parent PID:     24876
threads:        6
memory usage:   0.039%
cpu usage:      0.000%
username:       admin
cmd+args:       /tmp/go-build400100092/b001/exe/main
elapsed time:   08:06
local/remote:   127.0.0.1:34409 <-> 0.0.0.0:0 (LISTEN)

$ gops 24966 0.5
parent PID:     24876
threads:        6
memory usage:   0.039%
cpu usage:      0.000%
username:       admin
cmd+args:       /tmp/go-build400100092/b001/exe/main
elapsed time:   08:10
local/remote:   127.0.0.1:34409 <-> 0.0.0.0:0 (LISTEN)

$ gops 24966 1.2
parent PID:     24876
threads:        6
memory usage:   0.039%
cpu usage:      0.000%
username:       admin
cmd+args:       /tmp/go-build400100092/b001/exe/main
elapsed time:   08:19
local/remote:   127.0.0.1:34409 <-> 0.0.0.0:0 (LISTEN)

$ gops 24966 -7
parent PID:     24876
threads:        6
memory usage:   0.039%
cpu usage:      0.000%
username:       admin
cmd+args:       /tmp/go-build400100092/b001/exe/main
elapsed time:   08:26
local/remote:   127.0.0.1:34409 <-> 0.0.0.0:0 (LISTEN)

This is a very minor issue but would be helpful to fix to validate the user's input. It looks like this line here is not validating the returned values from period, err = time.ParseDuration(os.Args[2])

var period time.Duration
if len(os.Args) >= 3 {
	period, err = time.ParseDuration(os.Args[2])
	if err != nil {
		secs, _ := strconv.Atoi(os.Args[2])
		period = time.Duration(secs) * time.Second
	}
}

[tklauser]

@el10savio thanks for the report. I think it'd make sense to fix this. Want to open a PR?

[el10savio]

Thanks @tklauser. Sure, I can pick it up :)