Error out when the given duration is negative #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #154
Validate
processInfo
period & log a fatal error in the case of negative duration.Now gops exits and returns a fatal error in the case when the user supplies a negative duration to
gops <pid> <duration>
instead of defaulting to 0 as shown below.Previously:
Now:
Note:
In an attempt to validate the duration values, I skipped over validating floats as internally they get converted to the appropriate duration. for example
0.5s
internally gets converted to500ms