agent: use filepath.Join to construct portfile path #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If gopsdir contains a trailing slash, the resulting portfile path will contain a trailing double slash which might lead to problems in some circumstances. Moreover iut could also be problematic on platforms where other path separators are used (e.g. Windows). Fix this by using filepath.Join to construct the path.
|
Gotcha, thanks!
…On Tue, Mar 9, 2021 at 2:40 AM Tobias Klauser ***@***.***> wrote:
Good catch @tklauser <https://github.com/tklauser>, let’s also comb
through for more of such unportable path constructions. LGTM, and thank you!
Thanks for the review @odeke-em <https://github.com/odeke-em>. Some quick
greping didn't show any other obvious instances of these.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#140 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABFL3VY5OXMLX4OFT2HLRETTCX3H7ANCNFSM4Y3IROIQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
gopsdircontains a trailing slash, the resultingportfilepath willcontain a trailing double slash which might lead to problems in some
circumstances. Moreover iut could also be problematic on platforms where
other path separators are used (e.g. Windows).
Fix this by using
filepath.Jointo construct the path.