Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: Use strings.Contains #65

Merged
merged 1 commit into from
Dec 3, 2017
Merged

cmd: Use strings.Contains #65

merged 1 commit into from
Dec 3, 2017

Conversation

ferhatelmas
Copy link
Contributor

@ferhatelmas ferhatelmas commented Dec 3, 2017 •
edited
Loading

  • instead of strings.Index check

@ferhatelmas
cmd: Use strings.Contains
5b6e24c 
  - instead strings.Index check
odeke-em
odeke-em approved these changes Dec 3, 2017
View reviewed changes
Copy link
Collaborator

@odeke-em odeke-em left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ferhatelmas for the update, LGTM!

@odeke-em odeke-em merged commit f4d9617 into google:master Dec 3, 2017
@ferhatelmas ferhatelmas deleted the contains-index branch December 3, 2017 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odeke-em odeke-em odeke-em approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferhatelmas @odeke-em