Automate header stripping and make reducer header-aware #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PrettyPrintVisitor. Now paving the way for whether GraphicsFuzz headers are required to be figured out during reduction.
…context more generally than just for figuring out opportunities.
… Reducer uses this to decide whether to emit defines.
paulthomson
previously approved these changes
Oct 25, 2018
paulthomson
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we would pass around a boolean to say whether a shader was expected to have headers (containing GraphicsFuzz #defines) that should be stripped.
This PR changes things so that this is decided automatically based on whether the shader has a header.
As part of this, #version information is no longer stripped away - it is left and properly parsed. A knock-on effect is that a lot less version information need to be passed around in general, as it is now stored in translation units.
The reducer has been adapted to automatically decide whether to emit headers depending on whether the shaders being reduced contained them.