Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update repack info #75

Closed
wants to merge 2 commits into from
Closed

update repack info #75

wants to merge 2 commits into from

Conversation

pettai
Copy link

@pettai pettai commented Apr 27, 2017

Update the client repack docs to reflect the latest stable release of
ggr (thx to mbushkov@)

Update the client repack docs to reflect the latest stable release of
ggr
don’t forget build_contexts.py
@mbushkov
Copy link
Collaborator

mbushkov commented May 2, 2017

Thanks for the PR! The problem is that the current documentation is actually correct for the GRR version in HEAD. The instructions that you suggest are correct for the current GRR release version, which is quite old.

We can still probably update the docs, but then the current instructions have to be preserved, and the ones that worked for you should be formatted into a separate block, clearly stating that these instructions apply to an older GRR version.

@pettai
Copy link
Author

pettai commented May 3, 2017

ok, is there a new GRR release planned ?

@mbushkov
Copy link
Collaborator

mbushkov commented May 3, 2017

Most likely there will be a new GRR release next quarter (2017Q3).

@pettai
Copy link
Author

pettai commented May 4, 2017

Ok, we can skip my update if that's obsolete to the current code anyway. I know how to make repacked clients with labels, so I can keep those notes.
May I suggest that you make a new branch (release-3.x.y.) of the grr-doc then next GRR release occurs, so the branch stays true to the current stable release?

@pettai pettai closed this May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants