-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GTMSessionUploadFetcher: respect GTMSESSION_RECONNECT_BACKGROUND_SESSIONS_ON_LAUNCH flag #219
Conversation
…IONS_ON_LAUNCH flag
@mwyman I also have a question as for the default value of the flag |
Since this was a change in behavior, we gated it on using the latest target OS at the time to avoid an unexpected change in launch behavior; was considered (right or wrong) that projects that had targeted the latest OS at that time were staying more on-top of things. |
I see, that makes sense. We would prefer to have it as a default for all Firebase users but it's a bit difficult (not sure if possible at all) to set up without an extra step for developers. I guess, the default behaviour may be updated in conjunction with the major the version bump which will indicate the braking change for the library users. I assume most of the users lock the dependency on a particular major version. WDYT? |
GTMSessionFetcher.podspec
Outdated
@@ -2,7 +2,7 @@ | |||
# to import GTMSessionFetcher via the CocoaPods dependency Manager. | |||
Pod::Spec.new do |s| | |||
s.name = 'GTMSessionFetcher' | |||
s.version = '1.5.0' | |||
s.version = '1.6.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't bump the version number in this PR. We like to keep that separate from individual code changes.
d702a69
to
ef52779
Compare
Fix #218.
@mwyman I didn't really do a lot of testing, so additional verification from your end is appreciated.