Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now that the CanIgnoreReturnValue annotation is used throughout the code the dependency is no longer optional #2652

Closed

Conversation

cheister
Copy link

In version 20.0 the errorprone annotations are used throughout the codebase so the error_prone_annotations dependency is not optional anymore.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@cheister
Copy link
Author

I signed It!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@cpovirk
Copy link
Member

cpovirk commented Nov 21, 2016

It should still be "optional" in the Maven sense (meaning that it needs to be present when compiling Guava but not when compiling projects that use Guava. What problem are you seeing?

@cheister
Copy link
Author

Ok. I'm closing this PR so I can do more investigation. When we updated to version 20.0 we started getting

Error:java: cannot access com.google.errorprone.annotations.CanIgnoreReturnValue
  class file for com.google.errorprone.annotations.CanIgnoreReturnValue not found

when compiling the project in IntelliJ. The workaround is to explicitly add the error_prone_annotations dependency to our app but I'm not sure what part of our code is trying to use that annotation.

@cheister cheister closed this Nov 21, 2016
@cheister cheister deleted the errorprone-annotation-not-optional branch November 23, 2016 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants