Add Sets.toImmutableEnumSet() #2667 #2676
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mutableSet and ImmutableMap to work around fauxvsrride test: it was unable to handle generic types required for Enums currently.
…hed commit) Squashed commits: [80bbf86] Code and test for google#2667. Written in Sets and Maps instead of ImmutableSet and ImmutableMap to work around fauxvsrride test: it was unable to handle generic types required for Enums currently.
* commit '50d00427cfb835dbb8583d5f7ff8dffab3aabfad': Use Guava collectors to enforce same behavior in Exceptions Code and test for google#2667. Written in Sets and Maps instead of ImmutableSet and ImmutableMap to work around fauxvsrride test: it was unable to handle generic types required for Enums currently.
liach
reviewed
Dec 6, 2016
| Sets::immutableEnumSet); | ||
| } | ||
|
|
||
|
|
| */ | ||
| public static <T, K extends Enum<K>, V> Collector<T, ?, ImmutableMap<K, V>> toImmutableEnumMap( | ||
| java.util.function.Function<? super T, K> keyFunction, | ||
| java.util.function.Function<? super T, ? extends V> valueFunction) { |
There was a problem hiding this comment.
You should add @param and @return javadoc tags like methods below.
| public static <T, K extends Enum<K>, V> Collector<T, ?, ImmutableMap<K, V>> toImmutableEnumMap( | ||
| java.util.function.Function<? super T, K> keyFunction, | ||
| java.util.function.Function<? super T, ? extends V> valueFunction, | ||
| BinaryOperator<V> mergeFunction) { |
|
We did this about a week after this PR, way back when. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code and test in Sets and Maps instead.