Remove @Beta: Immutable{BiMap,List,Map,Set}.builderWithExpectedSize #3591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I modified Dagger so that its generated code is using `builderWithExpectedSize` for immutable collections whenever it's available, i.e., Guava 23.1 or later: google/dagger#1094 Since `builderWithExpectedSize` is a @beta API, if a Bazel client project depends on Dagger, and if the depended Dagger is using Guava 23.1 or later, Dagger generates code that uses this Guava @beta API, which fails ErrorProne, thus failing Bazel build: google/dagger#1569 The same issue could also happen if a Maven client project has a `maven-compiler-plugin` that also uses ErrorProne. If the Guava team feel confident about those `builderWithExpectedSize` static factory methods, maybe it's time to remove `@Beta` for them altogether. Happy to discuss. Thank you! Reference: https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis
|
Hello @ronshapiro ! How's going? Could you take a look at this PR, please? Thank you! |
|
Hi, again, Michael! I'll put this on our list of issues to consider when we start our new planning process in the coming month. |
|
This is now fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I modified Dagger so that its generated code is using
builderWithExpectedSizefor immutable collections whenever it'savailable, i.e., Guava 23.1 or later:
google/dagger#1094
Since
builderWithExpectedSizeis a @beta API, if a Bazel clientproject depends on Dagger, and if the depended Dagger is using
Guava 23.1 or later, Dagger generates code that uses this Guava
@beta API, which fails ErrorProne, thus failing Bazel build:
google/dagger#1569
The same issue could also happen if a Maven client project has a
maven-compiler-pluginthat also uses ErrorProne.If the Guava team feel confident about those
builderWithExpectedSizestatic factory methods, maybe it's timeto remove
@Betafor them altogether.Happy to discuss. Thank you!
Reference:
https://github.com/google/guava/wiki/PhilosophyExplained#beta-apis