Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be clearer about what types we're catching. #6033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Be clearer about what types we're catching. #6033

wants to merge 1 commit into from

Commits on Apr 30, 2022

  1. Be clearer about what types we're catching. 

    In particular, this helps make clearer that none of these particular `catch` blocks catch arbitrary checked exceptions—and thus that none of them catch `InterruptedException`.

Also, I've removed some `catch (Throwable t)` blocks from `FakeTimeLimiter`. They could never be hit, since previous blocks had caught both `Error` and `Exception` (in the case of `Callable`) or `RuntimeException` (in the case of `Runnable`).

RELNOTES=n/a
PiperOrigin-RevId: 444246111
    @cpovirk
    cpovirk authored and Google Java Core Libraries committed Apr 30, 2022
    Configuration menu
    Copy the full SHA
    bd5bfd6 View commit details
    Browse the repository at this point in the history