Include LICENSE in the generated jar under META-INF.
#6477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_530338363
branch
from
b502a5a
to
7d41e19
Compare
copybara-service bot
pushed a commit
to google/escapevelocity
that referenced
this pull request
May 8, 2023
See google/guava#6468 and google/guava#6477. RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/guava-beta-checker
that referenced
this pull request
May 8, 2023
See google/guava#6468 and google/guava#6477. RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/compile-testing
that referenced
this pull request
May 8, 2023
See google/guava#6468 and google/guava#6477. RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/jimfs
that referenced
this pull request
May 8, 2023
See google/guava#6468 and google/guava#6477. RELNOTES=n/a PiperOrigin-RevId: 530400894
This was referenced May 8, 2023
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
May 8, 2023
See google/guava#6468 and google/guava#6477. RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/compile-testing
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/guava-beta-checker
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/escapevelocity
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530400894
copybara-service bot
pushed a commit
to google/compile-testing
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530613491
copybara-service bot
pushed a commit
to google/guava-beta-checker
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530613491
copybara-service bot
pushed a commit
to google/truth
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530613491
copybara-service bot
pushed a commit
to google/escapevelocity
that referenced
this pull request
May 9, 2023
See google/guava#6468 and google/guava#6477. I cowardly did not look into Auto and its many pom.xml files. And I gave up on jimfs when its jar didn't end up containing the license... maybe somehow related to how it has other files autogenerated into `META-INF`?? RELNOTES=n/a PiperOrigin-RevId: 530613491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
LICENSEin the generated jar underMETA-INF.Fixes #6468
I'd looked at how Guice does this, which pulls the Apache license from a remote server (and also generates additional
DEPENDENCIESandNOTICEfiles). But I figured it was simplest to just pointmaven-resources-pluginat our localLICENSEfile:maven-resources-plugincan work with any license, whereas I'm not sure if Guice'sapache-jar-resource-bundleapproach can. Plus, I want to figuremaven-resources-pluginout, anyway, for Proguard purposes.Conveniently, I'm pretty confident that our existing
resourcesconfiguration isn't necessary: Maybe it was years ago, but nowadays, we have no results forfind */src android/*/src -type f -not -name '*.java'(except underguava-gwt, which overridesresourcesand which I verified builds an identical jar after this change).RELNOTES=n/a