added class PrimitiveMath, that focus on performing Addition Operatio…

[harishwar-babu]

Created a new class called PrimitiveMath , which has two static functionalities

• Addition(v1,v2) --> (for integer, long,short) --> returns integer value.
• isEven(v1) ---> (for integer,long,short) ---> returns boolean value.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[eamonnmcmanus]

Please see the How to Contribute document. We generally don't accept pull requests that add a new API without prior discussion. I note too that the code in this PR doesn't build.

[harishwar-babu]

ok, shall I discuss the new API that I have designed with you? Thanks Harish

…

On Mon, Feb 12, 2024 at 5:09 AM Éamonn McManus ***@***.***> wrote: Please see the How to Contribute <https://github.com/google/guava/blob/master/CONTRIBUTING.md> document. We generally don't accept pull requests that add a new API without prior discussion. I note too that the code in this PR doesn't build. — Reply to this email directly, view it on GitHub <#6982 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APVZW7BIV3XU5BHN23GIQSTYTFJCPAVCNFSM6AAAAABDDKBYOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHEYTIMBVG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[harishwar-babu]

ok, shall I discuss on the new API that I have designed with you?

…

On Mon, Feb 12, 2024 at 5:09 AM Éamonn McManus ***@***.***> wrote: Please see the How to Contribute <https://github.com/google/guava/blob/master/CONTRIBUTING.md> document. We generally don't accept pull requests that add a new API without prior discussion. I note too that the code in this PR doesn't build. — Reply to this email directly, view it on GitHub <#6982 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APVZW7BIV3XU5BHN23GIQSTYTFJCPAVCNFSM6AAAAABDDKBYOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZXHEYTIMBVG4> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[eamonnmcmanus]

The document I linked to explains the process. A proposed new API starts with a new issue describing what the API looks like and what use cases it addresses.

I will say, to save everyone time, that I think it is unlikely that an API like the proposed add will be accepted. The claim that a method adding integers by using bitwise operations is faster than the native + operator is frankly astonishing. I think you would need to produce some very convincing evidence in the form of benchmarks.

There is maybe slightly more justification for isEven, but I think most people know or can find out that they can write (i & 1) == 0 or i % 2 == 0.

[harishwar-babu]

Thanks for your Tip sure, will check out The bench mark. And I try to re- commit the code to avoid build failure issue. Thanks Harish

…

On Mon, 12 Feb, 2024, 11:49 pm Éamonn McManus, ***@***.***> wrote: The document I linked to explains the process. A proposed new API starts with a new issue describing what the API looks like and what use cases it addresses. I will say, to save everyone time, that I think it is unlikely that an API like the proposed add will be accepted. The claim that a method adding integers by using bitwise operations is faster than the native + operator is frankly astonishing. I think you would need to produce some very convincing evidence in the form of benchmarks. There is maybe *slightly* more justification for isEven, but I think most people know or can find out that they can write (i & 1) == 0 or i % 2 == 0 . — Reply to this email directly, view it on GitHub <#6982 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APVZW7GENGSDBWRJMKLVH73YTJMLFAVCNFSM6AAAAABDDKBYOSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZZGI4TANBVHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[harishwar-babu]

So, shall I attach the file about the bench marks and justification in this thread. for your reference.