Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent handling of metadata #100

Closed
robryk opened this issue Mar 20, 2017 · 0 comments
Closed

Inconsistent handling of metadata #100

robryk opened this issue Mar 20, 2017 · 0 comments
Assignees
@robryk
Labels
bug

Comments

@robryk
Copy link
Contributor

robryk commented Mar 20, 2017

It appears that we drop metadata when we intend to preserve it when generating a YUV420 output.
@robryk robryk added the bug label Mar 20, 2017
@robryk robryk self-assigned this Mar 20, 2017
robryk added a commit to robryk/guetzli that referenced this issue Mar 20, 2017
@robryk
Handle app data consistently.
e3ec8fa 
We used to drop app data iff the output was YUV420 or strip_metadata was
enabled. This fixes google#100.
robryk added a commit to robryk/guetzli that referenced this issue Mar 20, 2017
@robryk
Always strip color profiles & app-specific metadata.
a533bc0 
We used to, due to a bug, strip metadata only for YUV420 output (google#100).
We should rather strip it always and explicitly warn that input should
be sRGB.

This way, if Guetzli is provided an image in a different profile, the
result will be very obviously wrong. Were we to keep color profiles by
default, the result would then be subtly wrong.

Strippping other metadata is the choice most of the web image optimizers
make. If we find out that it's undesirable for some users, we can simply
add a flag to control this behaviour.
robryk added a commit to robryk/guetzli that referenced this issue Mar 20, 2017
@robryk
Always strip color profiles & app-specific metadata.
13aa71e 
We used to, due to a bug, strip metadata only for YUV420 output (google#100).
We should rather strip it always and explicitly warn that input should
be sRGB.

This way, if Guetzli is provided an image in a different profile, the
result will be very obviously wrong. Were we to keep color profiles by
default, the result would then be subtly wrong.

Strippping other metadata is the choice most of the web image optimizers
make. If we find out that it's undesirable for some users, we can simply
add a flag to control this behaviour.
jyrkialakuijala pushed a commit that referenced this issue Mar 20, 2017
@robryk @jyrkialakuijala
Always strip color profiles & app-specific metadata.
4234b62 
We used to, due to a bug, strip metadata only for YUV420 output (#100).
We should rather strip it always and explicitly warn that input should
be sRGB.

This way, if Guetzli is provided an image in a different profile, the
result will be very obviously wrong. Were we to keep color profiles by
default, the result would then be subtly wrong.

Strippping other metadata is the choice most of the web image optimizers
make. If we find out that it's undesirable for some users, we can simply
add a flag to control this behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robryk robryk

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robryk