Update asm version to 9.4.

[jaroslawr]

Fixes #1654.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[jaroslawr]

(I added the CLA)

[ninja-]

In the meantime, I would recommend excluding transitive asm dependency in your build.gradle and shading your own version of asm, for anyone needing Java 19

[nikammerlaan]

@ninja- Can you elaborate on how you excluded ASM? Guice relocates ASM into it's own source, so it's not as simple as a regular transitive dependency override.

[mcculls]

The jar before ASM is shaded is kept as part of the build process, for 5.1.0 it can be found at: https://repo1.maven.org/maven2/com/google/inject/guice/5.1.0/guice-5.1.0-classes.jar or using Maven: <dependency> <groupId>com.google.inject</groupId> <artifactId>guice</artifactId> <classifier>classes</classifier> <version>5.1.0</version> </dependency> you can then add your own version of ASM on the classpath and it should pick it up.

…

On Wed, 5 Apr 2023 at 19:23, Nik Ammerlaan ***@***.***> wrote: @ninja- <https://github.com/ninja-> Can you elaborate on how you excluded ASM? Guice relocates ASM into it's own source, so it's not as simple as a regular transitive dependency override. — Reply to this email directly, view it on GitHub <#1657 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABDTO67VCK6R5GOMQBSCKTW7W2DXANCNFSM6AAAAAASENIAYY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[ninja-]

@nikammerlaan right, if it's relocated I probably missed that. in such case the reason why my app is still working on newest Java, is that I left the compiler versions at earlier Java:

configure<JavaPluginExtension> {
    sourceCompatibility = JavaVersion.VERSION_15
    targetCompatibility = JavaVersion.VERSION_15
}

tasks.withType<KotlinCompilationTask<KotlinJvmCompilerOptions>>().configureEach {
    compilerOptions {
        jvmTarget.set(JvmTarget.JVM_15)
    }
}

it doesn't seem to have any negative consequences, especially that I am using Kotlin