MOE Sync 2020-07-09 #1359
MOE Sync 2020-07-09 #1359
Conversation
Replace CGLIB with custom code to generate "enhancers" and "fast-classes". Some user visible changes from using cglib: - intercepted method that has a return type of int but returns null from the interceptor will no longer be automatically converted to 0, instead a NullPointerException will be thrown. - Scope implementation can no longer check for circular proxy instance using CircularDependencyProxy marker class, instead should use Scopes.isCircularProxy - Depending on which custom class loading option is used, Guice enhanced class may no longer be mockable/spyable - Generated class name is slightly longer. Closes #1298 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=320433559
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This code has been reviewed and submitted internally. Feel free to discuss on
the PR, and we can submit follow-up changes as necessary.
Commits:
Import https://github.com//pull/1298
Replace CGLIB with custom code to generate "enhancers" and "fast-classes".
Some user visible changes from using cglib:
Closes #1298
2d867c5