Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add InlineMe to Modules.combine(Module), as all callers to this method can be simplified to just the input parameter. #1816

Merged
1 commit merged into from
May 7, 2024
Merged

Add InlineMe to Modules.combine(Module), as all callers to this method can be simplified to just the input parameter. #1816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion core/src/com/google/inject/util/Modules.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import com.google.common.collect.Maps;
import com.google.common.collect.Sets;
import com.google.errorprone.annotations.CheckReturnValue;
import com.google.errorprone.annotations.InlineMe;
import com.google.inject.AbstractModule;
import com.google.inject.Binder;
import com.google.inject.Binding;
Expand Down Expand Up @@ -122,7 +123,10 @@ public static Module combine(Module... modules) {
return combine(ImmutableSet.copyOf(modules));
}

/** @deprecated there's no need to "combine" one module; just install it directly. */
/**
* @deprecated there's no need to "combine" one module; just install it directly.
*/
@InlineMe(replacement = "module")
@Deprecated
public static Module combine(Module module) {
return module;
Expand Down