-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
s6-mkfifo: fatal: unable to mkfifo #1102
Comments
Some additional debugging attempts / info: Mounting /var as an emptydir ( |
|
@fvoznika I could probably add an admission webhook if that's required - mounting tmpfs easily without requiring additional steps inside the container is the goal - unfortunately in this situation I don't have a lot of control over the images themselves. Any link to said admission controller / hints? Edit: Not sure i'm clear on the annotation / webhook relation - the annotation doesn't work without a webhook? Or, are you suggesting I use an admission controller to force the annotation? Sorry if im being a bit thick here :P |
Fixes #1102 PiperOrigin-RevId: 278011384
@erulabs it'll be better to just allow namedpipes to be created on any mount, as you don't really have control over the location where namedpipes can be created for all applications. Can you check if #1135 fixes the issue for you? I get further running |
When trying to setup a local minikube + knative + gvisor setup, with an s6-overlay based container, I ran into this issue as well. Tried to see what #1135 did for me, and the mkfifo-error disappeared, but I got a new one instead: Going to figure out how to enable debug-logging in this setup, and try to get a minimal reproducable setup. |
I only briefly looked at the s6 code, but there are a bunch of uses of MSG_NOSIGNAL (https://github.com/skarnet/skalibs/search?q=sendmsg&unscoped_q=sendmsg), which gVisor doesn't support, which could be the cause of this. cc @iangudger |
We effectively do support MSG_NOSIGNAL as we always do the MSG_NOSIGNAL
behavior. We never send signals in the cases that MSG_NOSIGNAL affects.
|
Oops, apologies. I read
|
Internal pipes are supported similarly to how internal UDS is done. It is also controlled by the same flag. Fixes #1102 PiperOrigin-RevId: 278011384
Internal pipes are supported similarly to how internal UDS is done. It is also controlled by the same flag. Fixes #1102 PiperOrigin-RevId: 278011384
@wmuizelaar hrm - thanks for the reply :) @amscanne I'm using nightly gVisor (runsc --version returns runsc version release-20190806.1-329-g1c480abc39b9) and s6-overlay 1.22.0 and 1.22.1 and get this issue with both versions of s6:
I've tried mounting an EmptyDir after looking at the tmpfs stuff at /var/run and get the same issue - Here is a Kubernetes example: https://kubesail.com/template/erulabs/sonarr/1 (Running that on KubeSail reproduces the error - KubeSail uses gVisor under the hood 💃)
Let me know if that's helpful - I'll keep digging on my side. Thanks!
Originally posted by @erulabs in #139 (comment)
The text was updated successfully, but these errors were encountered: