Migrate APInt attribute arguments to Builtin_IntegerAttr #222
Conversation
|
Fixes #204 |
|
|
||
| let builders = [ | ||
| AttrBuilderWithInferredContext<(ins "APInt": $cmod, "Polynomial":$ideal), [{ | ||
| return $_get(ideal.getContext(), cmod.getBitWidth(), cmod, ideal); | ||
| AttrBuilderWithInferredContext< |
There was a problem hiding this comment.
do you end up using this builder? i was slightly concerned about the use of zextOrTrunc here, so if it's unused (I don't see it in the diff, and it appears different) maybe best to remove it until tested or needed
There was a problem hiding this comment.
Oh, maybe this is used when the parser sees the : i<width> specified?
There was a problem hiding this comment.
So the builder can be used without parsing IR at all. It's just a function any old fool can call. If that fool (me) passes an IntegerType that is i32 but an APInt with underlying 64 bits, then I believe anyone who later assk for the APInt back will still have it in 64 bits. This is supposed to ensure that the integer type and the APInt's bit width always match.
I am actually not sure which builders the parser uses...
There was a problem hiding this comment.
Ah, yes when fixing my PR just now, I found out the default generated parser uses a builder (with IntegerAttr type param) like
LWEParamsAttr::get(odsParser.getContext(),
IntegerAttr((*_result_cmod)),
unsigned((*_result_dimension)));
and it ensured that the _result_cmod was a parser that can gather the type attribute on the int.
This is supposed to ensure that the integer type and the APInt's bit width always match.
I guess what I'm asking is - do you need it right now if you have no callers?
There was a problem hiding this comment.
Fair enough, I thought I was using it. Removed.
j2kun
force-pushed
the
reproduce-apint-failure
branch
from
d60b8a6
to
e10ad45
Compare
j2kun
force-pushed
the
reproduce-apint-failure
branch
from
e10ad45
to
38eee4a
Compare
j2kun
added
the
pull_ready
Fixes #221