Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HEIR polynomial dialect with upstream dialect #675

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Replace HEIR polynomial dialect with upstream dialect #675

merged 1 commit into from
Jun 6, 2024

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented May 8, 2024 •
edited
Loading

@j2kun j2kun marked this pull request as draft May 8, 2024 00:16
@j2kun j2kun mentioned this pull request May 8, 2024
Closed
AlexanderViand-Intel added a commit to AlexanderViand-Intel/heir that referenced this pull request May 13, 2024
@AlexanderViand-Intel
re-enable (heir::)polynomial in lsp-server
29252e3 
This was disabled in google#616 but re-enabling does not seem to cause any
issues.

TODO: the reference to heir::polynomial should be removed as part of google#675
@j2kun j2kun force-pushed the upstream-poly branch 2 times, most recently from 9a4df11 to dbd20b4 Compare May 20, 2024 06:18
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label May 21, 2024
@j2kun j2kun mentioned this pull request May 23, 2024
Closed
@j2kun j2kun removed the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label May 28, 2024
@j2kun j2kun force-pushed the upstream-poly branch 2 times, most recently from 5ec4acd to cff59c3 Compare May 29, 2024 23:20
@j2kun
Copy link
Collaborator Author

j2kun commented May 30, 2024

Main remaining problem is that the openfhe end_to_end tests don't build. heir-translate is apparently not able to load the Polynomial dialect's attributes, despite the fact that it's properly loaded upstream.

LLVM ERROR: can't create Attribute 'mlir::polynomial::IntPolynomialAttr' because storage uniquer isn't initialized: the dialect was likely not loaded, or the attribute wasn't added with addAttributes<...>() in the Dialect::initialize() method.

@j2kun j2kun mentioned this pull request May 31, 2024
Open
@j2kun j2kun marked this pull request as ready for review June 1, 2024 00:15
@j2kun
Copy link
Collaborator Author

j2kun commented Jun 1, 2024

All the fixes are in, and now we just need to wait until the upstream changes are integrated into HEIR, probably will happen on Monday.

@j2kun j2kun requested a review from asraa June 1, 2024 00:16
asraa
asraa approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!! Just a handful of small nits. So cool that it's on MLIR upstream now

tests/polynomial/runner/generate_test_cases.py Show resolved Hide resolved
lib/Conversion/PolynomialToStandard/PolynomialToStandard.cpp Outdated Show resolved Hide resolved
lib/Conversion/PolynomialToStandard/PolynomialToStandard.cpp Show resolved Hide resolved
lib/Conversion/PolynomialToStandard/PolynomialToStandard.cpp Outdated Show resolved Hide resolved
lib/Dialect/Polynomial/Transforms/NTTRewrites.td Show resolved Hide resolved
@j2kun j2kun force-pushed the upstream-poly branch 3 times, most recently from c617b74 to 1c43c68 Compare June 4, 2024 19:02
asraa
asraa approved these changes Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@j2kun
Replace HEIR polynomial dialect with upstream
e6ee4ec 
This does not upstream any of the polynomial
conversion passes, just the types, ops, attributes,
canonicalization patterns, and related verifiers, etc.
@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jun 4, 2024
@j2kun
Copy link
Collaborator Author

j2kun commented Jun 4, 2024

We're still missing the last upstream PR that will fix the remaining test failure

@asraa asraa mentioned this pull request Jun 5, 2024
Closed
@copybara-service copybara-service bot merged commit ae251e8 into google:main Jun 6, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asraa asraa asraa approved these changes

Assignees
No one assigned
Labels
pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

poly: upstream polynomial dialect
2 participants
@j2kun @asraa