Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add modular add/sub/mul ops to arith_ext #725

Merged

Conversation

AlexanderViand-Intel
Copy link
Collaborator

As discussed in #724

Copy link
Collaborator

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AlexanderViand-Intel
Copy link
Collaborator Author

Test failure seems to be unrelated and due to the switch to upstream polynomial:
ERROR: /home/runner/work/heir/heir/tests/openfhe/end_to_end/BUILD:18:24: Action tests/openfhe/end_to_end/simple_sum_lib.h failed: (Segmentation fault):

@AlexanderViand-Intel
Copy link
Collaborator Author

Rebased onto current main

@j2kun j2kun added the pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing label Jun 11, 2024
lib/Dialect/ArithExt/IR/ArithExtOps.td Outdated Show resolved Hide resolved
lib/Dialect/ArithExt/IR/ArithExtOps.td Show resolved Hide resolved
@copybara-service copybara-service bot merged commit 6435cc4 into google:main Jun 11, 2024
9 of 10 checks passed
@AlexanderViand-Intel AlexanderViand-Intel deleted the modular_arith_ext_ops branch June 27, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialect: mod_arith pull_ready Indicates whether a PR is ready to pull. The copybara worker will import for internal testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants