Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sancov.c #78

Closed
wants to merge 1 commit into from
Closed

Conversation

bryonglodencissp
Copy link

[../honggfuzz-master/sancov.c:454]: (error) Common realloc mistake: 'mapsBuf' nulled but not freed upon failure

This solution from Stack Overflow was helpful in fixing the error because if realloc cannot find enough space, it returns a null pointer, and leaves the previous region allocated.

Found by https://github.com/bryongloden/cppcheck

[[../honggfuzz-master/sancov.c:454](https://github.com/google/honggfuzz/blob/master/sancov.c#L454)]: (error) Common realloc mistake: 'mapsBuf' nulled but not freed upon failure

**[This solution](http://stackoverflow.com/a/1607031) from Stack Overflow was helpful in fixing the error because if realloc cannot find enough space, it returns a null pointer, and leaves the previous region allocated.** 

Found by https://github.com/bryongloden/cppcheck
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bryonglodencissp
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@robertswiecki
Copy link
Collaborator

Thanks, good catch. I decided to solve it everywhere :) f49962d

@bryonglodencissp bryonglodencissp deleted the patch-1 branch July 26, 2016 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants