Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

Adding router for ajaxified links #94

Merged
merged 8 commits into from
Jan 6, 2015
Merged

Adding router for ajaxified links #94

merged 8 commits into from
Jan 6, 2015

Conversation

devnook
Copy link
Contributor

@devnook devnook commented Jan 6, 2015

This is based on Eric's #92, with some additional changes added on top of it.

What got changed from original PR:

  • Router lives in a separate file
  • History and back button is supported
  • Navigation links get highlighted on navigation
  • All templates are injected in the same way, be template "ref" property

@devnook
Copy link
Contributor Author

devnook commented Jan 6, 2015

<i18n-msg msgid="attend-onsite">Attend onsite</i18n-msg>
</a>
</paper-tab>
<paper-tab>
<paper-tab label="offsite">
<a href="offsite.html" layout horizontal center>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-ajax-link

<i18n-msg msgid="attend-onsite">Attend onsite</i18n-msg>
</a>
</paper-tab>
<paper-tab>
<paper-tab label="offsite">
<a href="offsite.html" layout horizontal center>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data-ajax-link

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no partial for registration yet, so i'd rather get a simple 404 here.

@ebidel
Copy link
Contributor

ebidel commented Jan 6, 2015

Reviewed

@devnook
Copy link
Contributor Author

devnook commented Jan 6, 2015

PTAL

@ebidel
Copy link
Contributor

ebidel commented Jan 6, 2015

LGTM. I'm going to wait for the CI to see if it's working. Otherwise, will merge

@devnook
Copy link
Contributor Author

devnook commented Jan 6, 2015

I checked CI with Alex. there are bower-related problems, but probably nothing related to this PR in particular.

@jeffposnick
Copy link
Contributor

👍 from a service worker caching perspective. Nifty that you all got this working!

@ebidel
Copy link
Contributor

ebidel commented Jan 6, 2015

Actually, I think we want: pageMeta.title ? pageMeta.title + ' - Google I/O 2015' : 'Google I/O 2015';. Meaning keep the "Google I/O 2015" somewhere in the title.

@ebidel
Copy link
Contributor

ebidel commented Jan 6, 2015

Going to merge this. I'll follow up with a title cl.

ebidel added a commit that referenced this pull request Jan 6, 2015
Adding router for ajaxified links
@ebidel ebidel merged commit 4fddba6 into google:master Jan 6, 2015
@ebidel ebidel deleted the schedule2 branch January 6, 2015 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants