This repository has been archived by the owner on Dec 5, 2022. It is now read-only.
Adding router for ajaxified links #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <i18n-msg msgid="attend-onsite">Attend onsite</i18n-msg> | ||
| </a> | ||
| </paper-tab> | ||
| <paper-tab> | ||
| <paper-tab label="offsite"> | ||
| <a href="offsite.html" layout horizontal center> |
| <i18n-msg msgid="attend-onsite">Attend onsite</i18n-msg> | ||
| </a> | ||
| </paper-tab> | ||
| <paper-tab> | ||
| <paper-tab label="offsite"> | ||
| <a href="offsite.html" layout horizontal center> |
There was a problem hiding this comment.
There's no partial for registration yet, so i'd rather get a simple 404 here.
|
Reviewed |
|
PTAL |
|
LGTM. I'm going to wait for the CI to see if it's working. Otherwise, will merge |
|
I checked CI with Alex. there are bower-related problems, but probably nothing related to this PR in particular. |
|
👍 from a service worker caching perspective. Nifty that you all got this working! |
|
Actually, I think we want: |
|
Going to merge this. I'll follow up with a title cl. |
ebidel
added a commit
that referenced
this pull request
Jan 6, 2015
Adding router for ajaxified links
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on Eric's #92, with some additional changes added on top of it.
What got changed from original PR: